Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/demo vue #321

Merged
merged 23 commits into from
Jul 23, 2024
Merged

Fix/demo vue #321

merged 23 commits into from
Jul 23, 2024

Conversation

hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Jul 9, 2024 •
edited
Loading

This PR is about:

  • Upgrade use @toruslabs/vue-components, @toruslabs/vue-icons package
  • Update to new <script setup> tag in vue3
  • Update to new W3A design system
  • Fix minor bugs
  • Migrate from vue-cli to vite

@hieu-w hieu-w changed the title [WIP] Fix/demo vue Fix/demo vue Jul 10, 2024
chaitanyapotti
chaitanyapotti approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 6bb0cb8 into master Jul 23, 2024
1 check passed
@chaitanyapotti chaitanyapotti deleted the fix/demo-vue branch July 23, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@smgv smgv Awaiting requested review from smgv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieu-w @chaitanyapotti